Comments on: Rails 2.1 + Theme Plugin

By: Kirk Bushell

Kirk Bushell — Tue, 03 Mar 2009 00:10:08 +0000

I have tried so many versions of this, and I cannot seem to get it to work, specifically, I’m at the exact same problem I had when trying to do this myself – layouts do not seem to get loaded. Anyone having this issue and how the hell do I get around it? I’ve moved all my view files into themes/default. I’m currently using Rails 2.1.0.

By: Alan Harper

Alan Harper — Tue, 26 Aug 2008 01:39:48 +0000

I’ve collected together the bits and pieces of patches, and uploaded to github: http://github.com/aussiegeek/theme_support

By: terry

terry — Sun, 27 Jul 2008 14:03:23 +0000

Do those use different helpers to find the templates?

If you try to do it from the console, can you trace it to see where it’s looking?

By: joost

joost — Sun, 27 Jul 2008 14:01:18 +0000

I have the following problem (using Theme Plugin + Globalize):
It doesn’t seem to work when rendering inside blocks, like:
render :page do RJS stuff!
Same for yield magic:
content_for :something do
…
end

Any ideas?

By: tobiwankenobi

tobiwankenobi — Tue, 08 Jul 2008 15:48:47 +0000

Hi!

I still have some problems with the Theme-Plugin. Or maybe I just don’t understand right.

After changing to the theme_plugin I deleted my public/images, public/javascripts directories and moved the contents into the /themes/default/-Folders.

But now it seems that these files aren’t used. When I use the command “theme_javascript_include_tag ‘default’, ‘prototype” the error is:
“Cannot read file /themes/prototype/javascript/”
thats surely wrong, because prototype is the library to load?

Also, do I now have to use theme_image_tag instead image_tag? Seems so, because the theme_plugin otherwise searches in public/images.

By: Steffen

Steffen — Tue, 08 Jul 2008 14:09:40 +0000

Hmm… even the last one didn’t work if I was rendering partials directly from controller. The reason seems to be that all this only affects the TemplateFinder, if there is a render command inside a template. Else, the render method in ActionController::Base is used, which is uneffected by the theme_support patches.

An alternative solution: use ActionController::prepend_view_path directly from a before_filter. That helps in my case, and makes all patches to ActionView::Base unnecessary.

By: Kevin Ansfield

Kevin Ansfield — Tue, 08 Jul 2008 09:43:09 +0000

Oops, my bad. Looks like I was attempting this against rails edge as my git submodule wasn’t checked out on the right tag.

Have now got it working fine with Rails 2.1.0 but edge seems to have already changed a fair bit with regards to templates.

By: Kevin Ansfield

Kevin Ansfield — Mon, 07 Jul 2008 17:06:35 +0000

I’ve just tried this patch, but I keep running into an error with @finder:

NoMethodError (You have a nil object when you didn’t expect it!
The error occurred while evaluating nil.prepend_view_path):
/vendor/plugins/theme_support/lib/patches/actionview_ex.rb:16:in `render_file’

Should the @finder variable be set elsewhere?

Thanks.

By: terry

terry — Tue, 24 Jun 2008 14:40:09 +0000

@Nate
Nice catch, sir. That clearly isn’t necessary (since it works just fine without it, and reportedly better), so I’m going to update the post (and my local code!) to reflect it.

Thanks!

By: Nate

Nate — Tue, 24 Jun 2008 11:06:41 +0000

I’m curious why we need to do the finder.pick_template? If you stick the paths to the search path, isn’t Rails supposed to be able to find the template on its own now these days with 2.1? So I changed the render code above to be:

http://www.pastie.org/221034

So all it’s essentially doing is prepending the new view paths out of the themes directory and letting rails find them on its own by calling the old aliased render, and it seems to do the job. And it also doesn’t screw with @first_render apparently, which makes assert_template work again as expected.